[log_1213.txt - see lines with '**' for disposition - updated 12/15]

    fsgjt_cpl.h                 ** reviewed 14 December 2004
    fsgjt_job_document_page.h   ** reviewed 14 December 2004
    fsgjt_insert_sheet.h        ** reviewed 14 December 2004
    fsgjt_separator_sheet.h     ** reviewed 14 December 2004
    fsgjt_enums.h               ** reviewed 14 December 2004

--------------------
12/14/2004 - review

<1> 'fsgjt_job_document_page.h'
    - delete this header entirely - not part of external interface
    ** DONE **

<2> 'fsgjt_separator_sheet.h'
    - delete 'media' param from constructor
    ** DONE **

<3> 'fsgjt_enums.h'
    - rewrite the comment to 'are not included'
      - BindingTypeEnum, PrintContentOptimizeEnum, TrimmingTypeEnum
    ** DONE **

<4> 'fsgjt_enums.h'
    - rename 'BindTypeEnum' to 'BindingTypeEnum'
    ** DONE **

<5> 'fsgjt_enums.h' - in 'JobTicketTypeVersionEnum'
    - add '...JDF_1_3' (for mid-2005)
    ** DONE **

<6> 'fsgjt_enums.h' - in 'OutputBinNameEnum'
    - add plain '...MAILBOX', '...STACKER', '...TRAY'
    ** DONE **

<7> 'fsgjt_enums.h' - in 'SubscriptionEventEnum'
    - add '...JOB_STATE_ONLY_CHANGED'
    - add '...JOB_ERROR'
    - add '...JOB_WARNING'
    - alphabetize all values
    ** DONE **

<8> 'fsgjt_enums.h' - in 'Value Types'
    - delete '...NOT_SET'
    - change 'BIND_TYPE_ENUM' to 'BINDING_TYPE_ENUM'
    - delete '...BOOLEAN'
    - change '...CONTACT_TYPE' to 'CONTACT_INFO_ROLE'
    - delete '...DOUBLE'
    - change 'FOLD_TYPE_ENUM' to 'FOLDING_TYPE_ENUM'
    - change '...INSERT_SHEET' to 'INSERT_SHEET_OBJECT' (on right)
    - delete '...JOB_TICKET_INFO_OBJECT'
    - delete '...MANDATORY_ATTRIBUTES_ENUM'
    - change '...OUTPUT_BIN_ENUM' to 'OUTPUT_BIN_NAME_ENUM'
    - change '...PAGE_OVERRIDES' to '...PAGE_OVERRIDES_OBJECT'
    - change '...PREPRINTED_ENUM' to '...MEDIA_PREPRINTED_ENUM'
    - change '...SIZE_NAME' to '...MEDIA_SIZE_NAME'
    - change '...STITCH_TYPE_ENUM' to '...STITCHING_TYPE_ENUM'
    - change '...STRING' to '...TEXT'
    - change '...TRIM_TYPE_ENUM' to '...TRIMMING_TYPE_ENUM'
    - add '...CHARSET', '...NATURAL_LANGUAGE', and '...URI'
    - alphabetize all values after renames
    ** DONE **

<9> 'fsgjt.h' and Global - new type
    - add new 'fsgjt_text_t' type for 'char *'
    - change 'char *' to 'fsgjt_text_t' or 'fsgjt_text_t (Text)'
    - rename 'SetString...' methods to 'SetText...'
      (to agree with existing 'Text' abstract type in UML)
    ** DONE **

<10> Global - new type
    - change 'char *' to 'fsgjt_text_t' or 'fsgjt_text_t (Text)'
    ** DONE **

--------------------
Hi,                                            Monday (13 December 2004)

I've just posted Claudia's four updated header files in the directory:

    ftp://ftp.pwg.org/pub/pwg/fsg/jobticket/C_JTAPI_Code/Working/

in the files:

    fsgjt_cpl.h
    fsgjt_job_document_page.h
    fsgjt_insert_sheet.h
    fsgjt_separator_sheet.h

While editing, I found the following bugs:

(1) UML '03_JobTicketInfo.png' - in colored JobDocumentPage panel
    - delete 'trimming' (not in JTAPI/1.0)
    ** REJECTED ** keep as member of this abstract object

(2) UML '03_JobTicketInfo.png' - in Job white attributes panel
    - put asterisk in front of 'job-trimming' (not in JTAPI/1.0)
    ** ACCEPTED **

(3) UML '04_Job.png' - in colored SeparatorSheet Object
    - change 'mediaToUse' to 'media' in constructor (like attribute)
    ** REJECTED ** see <2> above - no longer applicable

Also found (but not changed):

(A) UML '04_Job.png' - in colored SeparatorSheet Object
    - change 'SeparatorSheetEnum' --> 'SeparatorSheetTypeEnum'
      (to agree with the attribute)
    ** REJECTED **


Cheers,
- Ira