[log_1101.txt - see lines with '**' for disposition - updated 12/15]

    fsgjt.h               ** reviewed 2 December 2004
    fsgjt_destination.h   ** reviewed 2 December 2004

    fsgjt_folding.h       ** reviewed 9 December 2004
    fsgjt_job_ticket_info.h ** reviewed 9 December 2004
    fsgjt_stitching.h     ** reviewed 9 December 2004

--------------------
12/02/2004 - review

<1> 'fsgjt.h'
    - add NaturalLanguage and Charset types w/ RFC references
    ** ACCEPTED **
    ** DONE **

<2> 'fsgjt.h'
    - IntegerType --> Integer
    - MediaSizeNameType --> MediaSizeName
    - URIType --> URI
    ** ACCEPTED **
    ** DONE **

<3> 'fsgjt.h'
    - improve documentation of Boolean (internal use only)
      - use PresentEnum for attributes
    ** ACCEPTED **
    ** DONE **

<4> 'fsgjt.h' - see Glen's comments
    - add 'fsgjtOpen/Close/Flush'
    ** ACCEPTED **
    ** DONE **

<5> 'fsgjt.h' - see item (B) below
    - fsgjtGet
      - change 'fsgjt_attribute_t' --> 'fsgjt_attribute_t*'
    ** ACCEPTED **
    ** DONE **

<6> Destination
    - change URIType --> URI
    ** ACCEPTED **
    ** DONE **

<7> Folding
    - see item (3) and (4) below
    ** ACCEPTED **
    ** DONE **

--------------------
12/09/2004 - review

<8> JobTicket
    - 'jt-api-charset' and 'jt_charset' (fix type)
      - fix Charset types w/ RFC references
    ** ACCEPTED **
    ** DONE **

<9> JobTicketInfo
    - remove 'charset' param from all four constructors
    ** ACCEPTED **
    ** DONE **

<10> JobTicketInfo
    - change 'char** buffer' to 'char* buffer' on methods
    ** ACCEPTED ** see item (A) below
    ** DONE **

<11> JobTicketInfo
    - add comment with advice about bufferSize (for WriteToBuffer)
    ** ACCEPTED ** see item (A) below
    ** DONE **

<12> Stitching
    - remove 'stitchingCount' and 'referenceEdge' from constructor
    ** ACCEPTED **
    ** DONE **

<13> HoleMaking
    - remove 'referenceEdge' from constructor
    ** ACCEPTED **
    ** DONE **


----------------------------------------
Hi folks,                                       Monday (1 November 2004)

I've just posted Glen's five updated header files in the directory:

    ftp://ftp.pwg.org/pub/pwg/fsg/jobticket/C_JTAPI_Code/Working/

in the files:

    fsgjt.h
    fsgjt_destination.h
    fsgjt_folding.h
    fsgjt_job_ticket_info.h
    fsgjt_stitching.h

also two updated files:

    fsgjt_enums.h
    fsgjt_job.h

also one missing file:

    fsgjt_trimming.h


While editing, I found the following bugs:

(1) UML '07_JobDocumentPage.png' - in colored Destination object
    - to be corrected in UML - fixed in headers already
    - 'uri' member --> 'targetUri'
      (consistent w/ attribute name)
    ** ACCEPTED **

(2) UML '07_JobDocumentPage.png' - in colored Destination object
    - to be corrected in UML - fixed in headers already
    - Destination constructor params incorrect
    - 'uri' param --> 'targetUri'
      (consistent w/ attribute name)
    ** ACCEPTED **

(3) UML '07_JobDocumentPage.png' - in colored Folding object
    - to be corrected in UML - fixed in headers already
    - 'FoldTypeEnum' --> 'FoldingTypeEnum'
      (consistent w/ attribute name)
    ** ACCEPTED **

(4) UML '07_JobDocumentPage.png' - in colored Folding object
    - to be corrected in UML - fixed in headers already
    - Folding constructor params incorrect
    - 'foldType' param --> 'foldingType'
      (consistent w/ attribute name)
    ** ACCEPTED **

(5) UML '03_JobTicketInfo.png' - in colored JobTicketInfo object
    - to be corrected in UML - fixed in headers already
    - 'jtCharset' member --> 'charset'
    - 'jtVersion' member --> 'version'
      (consistent w/ attribute names)
    ** REJECTED ** leave as is for clarity

(6) UML '03_JobTicketInfo.png' - in colored JobTicketInfo object
    - to be corrected in UML - fixed in headers already
    - JobTicketInfo constructor params incorrect
    - 'jtCharset' param --> 'charset'
      (consistent w/ attribute name)
    ** REJECTED ** leave as is for clarity

(7) UML '03_JobTicketInfo.png' - in colored JobTicketInfo object
    - to be corrected in UML - fixed in headers already
    - JobTicketInfo write methods w/ charset - should be deleted
    - methods with 'charset' param are redundant
      (because user can simply Set 'jt-charset' attribute first)
    ** ACCEPTED **

(8) UML '03_JobTicketInfo.png' - in colored JobTicketInfo object
    - to be corrected in UML - fixed in headers already
    - incorrect type on 'mandatoryAttributes' member
    - 'mandatoryAttributes : Mandatory AttributesEnum'
      --> 'mandatoryAttributes : list of text' (attribute names)
      (because this is supposed to give fine-grained user control - the
      corresponding 'job-mandatory-attributes' in PWG 5100.7 (Oct 2003)
      has a syntax of '1setOf type2 keyword', i.e., list of names)
    ** REJECTED ** use 'jt-fidelity' instead

(9) JTAPI Spec v0.93 - Section 18.1 - JobTicketInfo
    - 'jt-api-charset' has typo in 'D/H' class
    - {"UTF8:} --> {"UTF8"}
    ** ACCEPTED **

(10) JTAPI Spec v0.93 - all sections
    - global typo in footnotes - word order and capitalization
    - 'value the must' --> 'the value MUST'
    ** ACCEPTED **

(11) UML '07_JobDocumentPage.png' - in colored Stitching object
    - to be corrected in UML - fixed in headers already
    - 'StitchTypeEnum' --> 'StitchingTypeEnum'
      (consistent w/ attribute name)
    ** ACCEPTED **

(12) UML '07_JobDocumentPage.png' - in colored Stitching object
    - Stitching constructor params incorrect
    - 'stitchCount' param --> 'stitchingCount'
    - 'stitchType' param --> 'stitchingType'
      (consistent w/ attribute names)
    ** ACCEPTED ** but delete 'stitchingCount' parameter

(13) JTAPI Spec v0.93 - Section 21.1 - Stitching
    - need to fix required stitching angles
    - 'stitching-angle' - currently 'tbd' conformance
      - need to decide during JT WG telecons
    ** ACCEPTED ** every 45 degrees angle from 0 through 135

(14) JTAPI Spec v0.93 - Section 6.1 - fsgjtDestroy
    - inconsistent documentation on 'object' param
    - Change to "Object to free"
      (we only say 'pointer to...' for 'fsgjt_object_t*')
    ** ACCEPTED **
    ** DONE **

(15) JTAPI Spec v0.93 - Section 6.2 - fsgjtGet
    - inconsistent documentation on 'object' param
    - Change to "Object from which to get the attribute"
    ** ACCEPTED **
    ** DONE **

(16) JTAPI Spec v0.93 - Section 6.3 - fsgjtSet
    - inconsistent documentation on 'object' param
    - Change to "Object in which to set the attribute"
    ** ACCEPTED **
    ** DONE **

(17) JTAPI Spec v0.93
    - Section 6.4, 6.5, 6.6, 6.7, AND 6.8 (convenience functions)
    - incorrect name for 'attribute' param (input)
    - 'char* attribute' --> 'char* attributeName'
      (consistent with section 6.2 fsgjtGet)
    ** ACCEPTED **
    ** DONE **

(18) JTAPI Spec v0.93
    - Section 6.4, 6.5, 6.6, 6.7, AND 6.8 (convenience functions)
    - clarification of behaviour in 'Description' clause
    - 'destroys the attribute'
      --> 'destroys the temporary attribute'
    ** ACCEPTED **
    ** DONE **

(19) UML '07_JobDocumentPage.png' - in colored Trimming object
    - to be corrected in UML - fixed in headers already
    - 'TrimTypeEnum' --> 'TrimmingTypeEnum'
      (consistent w/ attribute name)
    ** ACCEPTED ** but delete Trimming header from JTAPI v1.0

(20) UML '07_JobDocumentPage.png' - in colored Trimming object
    - Trimming constructor params incorrect
    - 'trimType' param --> 'trimmingType'
      (consistent w/ attribute names)
    ** ACCEPTED ** but delete Trimming header from JTAPI v1.0

(21) UML '03_JobTicketInfo.png' - in white Job attributes list
    - incorrect attribute name
    - 'job-output-bin-name' --> 'job-output-bin'
      (because this is NOT a name - it's an enum)
    ** REJECTED ** keep Name in InputTray and OutputBin

(22) UML '03_JobTicketInfo.png' - in colored JobDocumentPage object
    - incorrect attribute name
    - 'outputBinName' --> 'outputBin' (like 'OutputBinEnum')
      (because this is NOT a name - it's an enum)
    ** REJECTED ** keep Name in InputTray and OutputBin


While editing, I found these questions (no header changes made):

(A) UML '03_JobTicketInfo.png' - in colored JobTicketInfo object
    - inconsistent type on 'buffer' param
    - JobTicketInfo constructor and write methods
    - 'char** buffer' --> 'char* buffer'
      (because the CALLER must always allocate the buffer)
    ** ACCEPTED **

(B) JTAPI Spec v0.93 - Section 6.2 - fsgjtGet
    - inconsistent type on 'attribute' param (output)
    - 'fsgjt_attribute_t attribute'
      --> 'fsgjt_attribute_t* attribute'
      (because the CALLER does NOT allocate the attribute - it's
      found and returned by the API library)
    ** ACCEPTED **

Cheers,
- Ira