[log_1030.txt - see lines with '**' for disposition - updated 12/15] fsgjt_contact_info.h ** reviewed 1 December 2004 fsgjt_hole_making.h ** reviewed 2 December 2004 fsgjt_media.h ** reviewed 2 December 2004 fsgjt_subscription.h ** reviewed 2 December 2004 -------------------- 12/01/2004 - review <1> ContactInfo - UML and/or Spec - see ** APPROVED ** on UML and Spec changes (1) through (4) below -------------------- 12/02/2004 - review <2> Media - delete 'media-recycled' - redundant w/ 'media-recycled-percentage' ** APPROVED ** ** DONE ** <3> Media - 'media-size-name' type of 'MediaSizeName' - add to 'fsgjt.h' ** APPROVED ** ** DONE ** <4> Media - 'media-type' - type to 'fsgjt_media_type_t' ** APPROVED ** ** DONE ** <5> Subscription - 'subscription-charset' - add type 'fsgjt_charset_t' to 'fsgjt.h' - IANA Charset Registry pointers ** APPROVED ** ** DONE ** <6> Subscription - 'subscription-natural-language' - add type 'fsgjt_natural_language_t' to 'fsgjt.h' ** APPROVED ** ** DONE ** <7> Subscription - delete second constructor 'fsgjtNewSubscriptionForEvent' ** APPROVED ** ** DONE ** ---------------------------------------- Hi folks, Saturday (30 October 2004) I've just posted four of Till's updated header files in the directory: ftp://ftp.pwg.org/pub/pwg/fsg/jobticket/C_JTAPI_Code/Working/ in the files: fsgjt_contact_info.h fsgjt_hole_making.h fsgjt_media.h fsgjt_subscription.h (reserving 'fsgjt_enums.h' until finishing with Glen's headers) While editing, I found the following bugs: (1) UML '04_Job.png' - in colored ContactInfo object - to be corrected in UML - fixed in headers already - 'types' member --> 'roles' - 'ContactInfoTypeEnum' --> 'ContactInfoRoleEnum' - 'contact-info-types' --> 'contact-info-roles' (in white box) (because it is NOT the type of the ContactInfo object) ** APPROVED ** (2) JTAPI Spec v0.93 - Section 9.1 - ContactInfo - inconsistent names - fixed in headers already - 'contact-info-types' --> 'contact-info-roles' (because it is NOT the type of the ContactInfo object) ** APPROVED ** (3) JTAPI Spec v0.93 - Section 9.1 - ContactInfo - need to fix required contact URI schemes for Production class - 'contact-info-contact-uri' - MUST support 'mailto:' (RFC 2368) and 'tel:' (RFC 2806) ** APPROVED ** (4) UML '04_Job.png' - in colored ContactInfo object - to be corrected in UML - fixed in headers already - params of both constructors are out-of-date - see new header for params that match the current attribute names ** APPROVED ** (5) JTAPI Spec v0.93 - Section 14.1 - HoleMaking - need to reorder attributes alphabetically - move 'hole-making-count' BEFORE 'hole-making-reference-edge' ** APPROVED ** (6) UML '07_JobDocumentPage.png' - in colored Media object - to be corrected in UML - fixed in headers already - 'inputTrayName' member --> 'inputTray' - 'InputTrayNameEnum' --> 'InputTrayEnum' (like 'OutputBinEnum') - 'media-input-tray-name' --> 'media-input-tray' (in white box) (because this is NOT a name - it's an enum) ** REJECTED ** keep Name in InputTray and OutputBin (7) JTAPI Spec v0.93 - Section 19.1 - Media - inconsistent names - fixed in headers already - 'media-input-tray-name' --> 'media-input-tray' (because this is NOT a name - it's an enum) ** REJECTED ** keep Name in InputTray and OutputBin (8) UML '07_JobDocumentPage.png' - in colored Media object - to be corrected in UML - fixed in headers already - 'PreprintedEnum' --> 'MediaPreprintedEnum' (like 'MediaColorEnum') ** APPROVED ** (9) UML '07_JobDocumentPage.png' - in colored Media object - to be corrected in UML - fixed in headers already - 'SizeName' type --> 'MediaSizeName' (defined in 'fsgjt.h') ** APPROVED ** (10) UML '04_Job.png' - in colored Subscription object - inconsistent names and invalid types - fixed in headers already - Subscription constructor - list of events is too complicated - 'eventsToDeliver : list of text' (plural and wrong type) --> 'event : SubscriptionEventEnum' (singular) ** REJECTED ** delete second constructor entirely (11) JTAPI Spec v0.93 - Section 22.1 - Subscription - need to fix required events for notification - 'subscription-events' - MUST support 'JOB_CONFIG_CHANGED' and 'JOB_STATE_CHANGED' (two top-level events that include everything but progress) (12) JTAPI Spec v0.93 - Section 22.1 - Subscription - need to fix required URI schemes for notification - 'subscription-send-to-uri' - MUST support 'mailto:' (RFC 2368) Cheers, - Ira